-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the parsing logic of makejdk_any_platform_args #3957
Conversation
Signed-off-by: Sophia Guo <[email protected]>
Grinder :https://ci.adoptium.net/view/Test_grinder/job/Grinder/10989/console
@andrew-m-leonard the build and error message I got |
grinder https://ci.adoptium.net/view/Test_grinder/job/Grinder/11002/ - unset SPEC temporarily. @andrew-m-leonard see the grinder unset SPEC temporarily is the test results good? |
@sophia-guo good to see unsetting SPEC resolved the autoconf failure The 3 differing files are caused by a failure in patching the SystemModule classes:
It was clearly not "Successful" !!
I am not sure why ${JDK_DIR} is not being resolved, but I wonder if these two functions should be changed to have it passed as a param, like all the others are:
It could also be an issue with the class names it is trying to find that contain $'s, I wonder if that fails for some reason on Windows... maybe it needs some special escaping for Windows?
|
https://ci.adoptium.net/view/Test_grinder/job/Grinder/11051/ - ReproduciblePercent = 100 % |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
Simplify the parsing logic of makejdk_any_platform_args (adoptium#3957) have forgot to add mandatpory parameter to usage of removeSystemModulesHashBuilderParams in tooling/reproducible/comparable_patch.sh#L351
Simplify the parsing logic of makejdk_any_platform_args (#3957) have forgot to add mandatpory parameter to usage of removeSystemModulesHashBuilderParams in tooling/reproducible/comparable_patch.sh#L351
Close #3955